feat: better expose HTTP Error header information in error handling on write #745
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Codecov ReportAttention: Patch coverage is
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #745 +/- ##
============================================
- Coverage 88.51% 88.50% -0.02%
+ Complexity 786 785 -1
============================================
Files 174 174
Lines 7195 7203 +8
Branches 405 405
============================================
+ Hits 6369 6375 +6
- Misses 696 697 +1
- Partials 130 131 +1 ☔ View full report in Codecov by Sentry. |
alespour
approved these changes
Aug 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes
Http Headers are already part of
InfluxException. In theWriteApithey can be accessed with anEventListener. WithWriteApiBlockingthey get thrown inwritemethod calls.InfluxExceptionNote that Cloud v3 and OSS v2 handle exceptional streamed or batched data on the server side a little bit differently. It appears that with v3 cloud batches of data that include some invalid records along with valid ones, will still write the valid records and return a success HTTP status code. OSS v2 on the other hand returns an error status triggering an exception.
Checklist
mvn testcompletes successfully